Try: Increase specificity of horizontal block margins. #30337
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasmussen
added
[Type] Regression
jasmussen
requested review from
draganescu,
youknowriad,
carolinan and
ntsekouras
|
How to test:
|
|
Size Change: +127 B (0%) Total Size: 1.42 MB
ℹ️ View Unchanged
|
|
Thanks for working on this Joen! I tested and seems to work as expected in top level Here is a gif. At first I have
|
|
Ack yes. This seems unsustainable. Right now we have this rule. Before we had this: that rule was troublesome enough (see #28878), but some of the block margin rule specificity was adapted to that. Now the rule is this, effectively: that's pretty high specificity, which means every theme or block that mitigated that rule needs higher specificity. Is there any way we can remove that margin rule? The issue is the same for the alignments inside, but those rules are better scoped and less intrusive. In absence of removing those margin rules, can we reduce their specificity? CC: @youknowriad |
I don't know, it's only useful for themes without theme.json files, so I'm not sure how we can still have the rule but only for these themes. |
This was referenced Mar 30, 2021
|
I'm happy to be able to close this one in favor of #30375 which is a better solution. I'd be grateful if you could help test and land that one! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A recent PR scoped the automatic left and right margins for
.wp-blockto themes that do not support layout. This is great because those left/right margins wreak havoc. See #29335.However in doing so, the
:notselector ended up adding specificity to the rule. That means theme rules that try to override those rules now fail in doing so. I don't know any good solution to this problem, other than adding additional specificity for those rules.It also had the side-effect of adding auto margins for some block styles. Specifically, it centered blocks inside flex containers, like Social Links, Navigation, and Buttons (auto margins in flex containers usually results in centered or space-between like layouts):
This PR fixes that by escalating the specificity for those blocks:
Finally, the higher specificity margin rules hid a bug in TwentyTwentyOne, where a blanket top-margin rule would cause a staircase effect on the Buttons block. Before this PR (note, the buttons block does not have space-between applied):
After this PR:
Note that the space-between effect has been fixed, and theme margins now affect the block. But they just affect the buttons block wrongly by targetting first-child and last-child rules, assuming they are in a vertical sequence:
TwentyTwenty does not have this problem:
Checklist:
*.native.jsfiles for terms that need renaming or removal).