Global Styles: Add padding server-side block support #30332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
[Feature] Block API
youknowriad
requested review from
spacedmonkey and
TimothyBJacobs
as code owners
23 tasks
|
Size Change: +805 B (0%) Total Size: 1.42 MB
ℹ️ View Unchanged
|
ntsekouras
approved these changes
Mar 29, 2021
There was a problem hiding this comment.
This works well! I also tested with some blocks like heading that when you add background some padding is applied, but if they have padding support it keeps the proper one from padding.
I pre-approve even if I left some small comments because more usage of gutenberg_block_has_support could be in a follow up.
Thanks Riad!
|
With the new changes there is a warning in
|
|
Good catch, it should be fixed |
|
LGTM! 🚢 |
7 tasks
gziolo
changed the title
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #28356
This PR adds the padding block support flag server-side allowing dynamic blocks to use it.
At the moment, it doesn't enable it for any block though (I'll leave that for you all designers to enable it on the blocks you like).
Testing instructions
spacing: { padding: true }to theblock.jsonof the dynamic block where you want to enable padding support.