In-between inserter: use useRefCallback, use showInsertionPoint #30285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +17 B (0%) Total Size: 1.39 MB
ℹ️ View Unchanged
|
mcsf
added
the
[Feature] Inserter
ellatrix
force-pushed
the
try/use-api-in-between-inserter
branch
2 times, most recently
from
4a8dd72 to
6870fe9
Compare
ellatrix
force-pushed
the
try/use-api-in-between-inserter
branch
from
6870fe9 to
8e01eaf
Compare
ellatrix
force-pushed
the
try/use-api-in-between-inserter
branch
from
87806ba to
248dc62
Compare
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I'm making this change to make the insertion point easier to work with for #29933 and #30153.
This PR changes the in-between inserter logic (on mouse move) to use the inserter point API instead of directly passing data to the inserter point itself. As a result, the event handler can be separated from the inserter point (just like the main inserter and drop logic is) and the insertion point only needs to look at one data point instead of merging two. We can now also use
useRefCallback.How has this been tested?
Try the in-between inserter by moving the mouse between blocks. Click the plus icon, navigate the popover, insert a block.
Screenshots
Types of changes
Checklist:
*.native.jsfiles for terms that need renaming or removal).