Navigation: add src/navigation-link/index to side effect whitelist #30200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 1.41 MB ℹ️ View Unchanged
|
sgomes
approved these changes
Mar 29, 2021
|
Thanks for the review @sgomes ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #30117 this adds the navigation-link to the side-effect whitelist, so our block hook will not be shaken out of the final build. Previously we were seeing expected behavior in the development build
npm run devbut not when usingnpm run buildTesting Instructions
WP 5.7
npm run buildand enable the gutenberg plugin. Note use the build and not dev command.Expected: all fallback variations appear: (link, post link, page link, category, tag)
WP Latest
npm run buildand enable the gutenberg plugin. Note use the build and not dev command.Expected: variations appear (including custom variations from plugins). Each variation has the correct icon. Note that when using custom variations, there's a new post label that plugin authors have not had a chance to add:
To see the right labels, we can edit the plugin and add
item_linkanditem_link_descriptionto the taxonomy or post-type definition.