Site Editor: Start in Select mode #30187
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Copons
added
[Feature] Site Editor
|
Size Change: +12 B (0%) Total Size: 1.41 MB
ℹ️ View Unchanged
|
|
Could this be beneficial for the post editor too? |
@ellatrix no idea, I've opened this PR for @jameskoster to play around 😄 |
|
Thanks @Copons :) I think there could be potential here. It certainly seems sensible for the modes to behave consistently regardless of whether you're in the site or post editor. And as templates are often more complex in terms of nesting, Select mode feels like a suitable default in the Site Editor. As a next step for this branch, it would be cool to revert the outline effects we currently see in edit mode in the site editor, so that it matches the post editor. Then we can explore updating the outline styles in Select mode based on the recent design work. I should be able to help with that part :D The one thing I'm struggling with a bit is how one gets back to Select mode when they're done editing a block. It should be a simple interaction that doesn't require clicking the mode selector. Clicking an empty space to deselect the current block and switch to the default mode makes sense. But there may not always be empty space, or the empty space may not be obvious. In #27849 (comment) the idea of having a "frame" of empty space around the template in the site editor has gained some traction, so perhaps that could serve this purpose. Edit: One oddity I noticed, and should be addressed – when Select mode is active in the post editor you have to click through container blocks to select the children. In the site editor you select the children directly. The post editor behaviour is preferred. This would effectively implement the click-through pattern explored in #30156 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
How has this been tested?
Screenshots
Types of changes
Checklist: