Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storybook playground - Fix block editor shortcuts #29750

Merged
merged 1 commit into from
Mar 11, 2021

Conversation

patricklindsay
Copy link
Contributor

Description

Small change that fixes block editor keyboard shortcuts within the storybook playground, came across the solution when reading a PR to fix shortcuts for the navigation widget - #28257

Originally this work was to fix an issue in the standalone editor getdave/standalone-block-editor#18 but then while working on that I realized that the storybook also had this issue.

How has this been tested?

  • Tested the live storybook and found that keyboard shortcuts were not working
  • Tested the development version of storybook and found that keyboard shortcut were not working
  • Made changes then retested development version of storybook and found that keyboard shortcuts were now working

Keyboard shortcuts tested;

  • backspace - when multiple blocks are selected - removes selected blocks
  • shift command D - when multiple blocks are selected - duplicates selected blocks

Types of changes

Bugfix

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Mar 11, 2021
@github-actions
Copy link

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @patricklindsay! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@gziolo gziolo added Storybook Storybook and its stories for components [Type] Bug An existing feature does not function as intended labels Mar 11, 2021
Copy link
Member

@gziolo gziolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thank you for your contribution 👍🏻

@gziolo gziolo merged commit 7bf8fe3 into WordPress:trunk Mar 11, 2021
@github-actions
Copy link

Congratulations on your first merged pull request, @patricklindsay! We'd like to credit you for your contribution in the post announcing the next WordPress release, but we can't find a WordPress.org profile associated with your GitHub account. When you have a moment, visit the following URL and click "link your GitHub account" under "GitHub Username" to link your accounts:

https://profiles.wordpress.org/me/profile/edit/

And if you don't have a WordPress.org account, you can create one on this page:

https://login.wordpress.org/register

Kudos!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository Storybook Storybook and its stories for components [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants