Reset all WP Admin styles in the wrapper of the editor styles. #29590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
requested review from
scruffian,
aristath,
kjellr,
jasmussen and
carolinan
youknowriad
requested review from
spacedmonkey and
TimothyBJacobs
as code owners
youknowriad
added
[Type] Technical Prototype
youknowriad
commented
Mar 5, 2021
| if ( 0 === strpos( $style['css'], "body { font-family:" ) ) { | ||
| unset( $settings['styles'][ $j ] ); | ||
| } | ||
| } |
There was a problem hiding this comment.
Core automatically loads a style setting a default font family, this hack removes that editor style (reset to browser defaults)
|
Size Change: +1.37 kB (0%) Total Size: 1.4 MB
ℹ️ View Unchanged
|
|
This is looking really good. There are still some differences but I don't think they are caused by this. One is the width of the editor: vs the width of the front end: The other one is the file block. Editor: Front end: The margins are also off but I think that will be done in a different issue? |
|
yes, some of the margins (the ones relying on figure) are fixed here #29517 And yeah, we won't be able to fix all in one go, we need to find a way to iterate and remove these differences bit by bit. |
|
This is so cool. |
|
I think we need to do this but I am worried about how it will effect existing themes. |
|
Something I consider is whether we could load the "default font style" but only for themes that don't provide any custom editor styles. That was the whole original idea of that "editor-styles.scss" file but somehow/somewhere it changed it got loaded for all themes (and I didn't know about it) |
carolinan
approved these changes
Mar 8, 2021
|
I see that @carolinan has 5 merged commits and a lot of other types of contributions that is more than enough fro Gutenberg team member status 😄 |
|
@gziolo I thought it was already the case 😬 It should be fixed. |
|
Let's give this a try and see how it goes. |
7 tasks
youknowriad
added
the
Needs Dev Note
15 tasks
youknowriad
removed
the
Needs Dev Note
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on top of #29588
Extends that approach applied to headings to lists and paragraphs and also resets the "body" (editor-styles-wrapper) styles to the browser defaults. (There are still some styles on the editor-styles.scss files that I didn't check yet)
The idea now, is that by default if you use the "emptytheme", the frontend looks exactly like the backend by default and as you add styles to both your stylesheet (and loaded as part of the editor styles), the frontend/backend parity will persist.