Social Links: Add color controls for the social links in a standard way #29565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -18 B (0%) Total Size: 1.4 MB
ℹ️ View Unchanged
|
bph
added
the
[Block] Social
scruffian
force-pushed
the
add/social-link-colors
branch
from
38b5b21
to
bf88329
Compare
20 tasks
oandregal
requested changes
Mar 9, 2021
There was a problem hiding this comment.
The direction is good. Sharing a few thoughts:
-
social link block: these changes look fine.
-
social links block:
- I presume the classes should remain the same:
has-icon-color,has-background-color - until we're able to change the labels of the UI controls Color controls: take labels from block supports #29155 I presume we can't land this.
- can we remove the unused block attributes?
- I presume the classes should remain the same:
I haven't looked into this deeply, and don't fully understand why we have 3 attributes for each color, so I'm going to pull @aaronrobertshaw @mkaz in case they can help with this review to make sure the refactor still covers all the original use cases.
|
The additional attribute was used to persist color selection between switching themes 6db9333. I'll take a closer look at this and add anything else I find. |
|
Closing this old PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This doesn't work, but I'm not sure what needs to be changed to get it working.
How has this been tested?
Screenshots
Types of changes
Checklist: