Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest Comments Block: Remove list padding and margin #29402

Merged
merged 4 commits into from
Mar 26, 2021
Merged

Latest Comments Block: Remove list padding and margin #29402

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9297f17
Latest Comments Block: Remove list padding and margin
carolinan Feb 27, 2021
00c6464
update latest comments editor styles
carolinan Mar 1, 2021
e8c22b2
Remove margin-left from the editor style.
carolinan Mar 2, 2021
533f292
Update style.css
carolinan Mar 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/block-library/src/latest-comments/editor.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
ol.wp-block-latest-comments.wp-block-latest-comments {
padding-left: 0;
}

.wp-block-latest-comments.has-avatars .avatar {
margin-right: 10px;
}
Expand Down
4 changes: 4 additions & 0 deletions packages/block-library/src/latest-comments/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
.wp-block-latest-comments {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can't we just use ol.wp-block-latest-comments here and avoid any specific editor style?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not understand. Did you mean to add this comment to the editor.scss file?
That might be possible now after #30034.
I will test it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no I mean replace the selector above with ol.wp-block-latest-comments and avoid any style in "editor.scss". It worked in my testing.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ol.wp-block-latest-comments is still overridden by

.editor-styles-wrapper ol, .editor-styles-wrapper ul {
    margin: revert;
    padding: revert;
}

that is why ol.wp-block-latest-comments.wp-block-latest-comments was used in the editor style.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is only overridden if the block is part of the post when it gets loaded in the editor. this is an issue with the lazy loading behavior of block assets in the editor. It affects more blocks than just the comments block I believe we should fix the root issue (stylesheet loading order) not its consequences. I already talked with @aristath and @gziolo about it.

padding-left: 0;
}

.wp-block-latest-comments__comment {
line-height: 1.1;
list-style: none;
Expand Down