RN: Button Block set the width to fixed when width is set #29360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +24.1 kB (+2%) Total Size: 1.41 MB
ℹ️ View Unchanged
|
geriux
added
the
Mobile App - i.e. Android or iOS
|
Hey @enejb I was testing this and it works great on iPhone but on Android, there's this issue:
Looks like it's adding some extra height to the buttons when the max width is limited to the min width. |
|
I did a bit of an investigation here and it seems that the root cause is that the Aztac Editor doesn't return the correct height back to the react native side. here I am not really sure how to go about fixing this. |
|
Thanks to @AmandaRiu, we were able to come up with a solution that works well. 🥳 |
geriux
approved these changes
Mar 24, 2021
enejb
deleted the
RN/fix/button-block-fixed-width-when-width-settings-set
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In #28543 we shipped a new button width setting.
However it doesn't quite work as expected. Since if you type too many characters the buttons width expands and takes the buttons don't fit on the row as expected any more.
This PR tried to fix that by setting the maxWidth to the minWidth if a width is set and not null. (Auto)
Before:
After:
How has this been tested?
Add 4 different 25% width Button blocks. Notice that they all fall in the same line. Take up the whole editor.
Set up different width buttons do things work out as expected?
Screenshots
25%
50% and 75%
Checklist: