Correct border radius value in settings of Button block #29193
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
Size Change: +172 B (0%) Total Size: 1.38 MB
ℹ️ View Unchanged
|
|
Closing in favor of #29263 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To fix #17596.
TODO: Maybe support the resize edge cases (which are mentioned below).
How has this been tested?
In the visual editor adding buttons with various style variations and changing their radii, then resetting their radii. Also by creating button style variations to confirm expected limitations of the implementation at present. Specifically buttons with a radius that changes depending on viewport size (See the second video).
Screenshots
Cases it aces
button-block-border-radius-part1.mp4
The asymmetric case is maybe not aced, but not showing a value there seemed the most sensible thing to do given the current UI.
Known Limitations
After the window resizes, buttons with a radius that varies depending on viewport size won't show the true radius in the settings.
button-block-border-radius-part2.mp4
Types of changes
Bug fix
Checklist: