Add a link completer for inline links to posts #29172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
draganescu
added
[Feature] Link Editing
|
Size Change: +428 B (0%) Total Size: 1.15 MB
ℹ️ View Unchanged
|
|
This is what I see:
Note that the positioning of the dropdown appears unrelated to this PR (see #28917 (comment)). My instinct here: this is really nice! It doesn't look like a lot of code complexity, but it's a really nice little feature for linking to existing stuff. It's so rare that I'd ever want to write Moreover, it doesn't weigh down the user interface, because it's just a "commandline tool", and it shares such DNA with the slash command already. I personally think there's a place for this. If others are fans, I'd tweak a few small things:
Nice work! |
draganescu
force-pushed
the
try/link-autocompleter
branch
from
d6c47ed to
605216e
Compare
|
Rebased to fix the wrong placement for the inserter. |
draganescu
force-pushed
the
try/link-autocompleter
branch
from
605216e to
dac258c
Compare
|
@jasmussen finally I found some time to come back to this. In this state:
|
|
Size Change: +502 B (0%) Total Size: 1.15 MB
ℹ️ View Unchanged
|
|
Works as advertised! @draganescu, this is a great use of Testing Notes
In the screencast below, I covered the following scenarios:
29172-link-completer-test.mp4 |
|
Took it for a spin: Seems cool! It's a pretty power-user specific feature, but since it doesn't weigh the UI at all, it's a nice balance. If it doesn't affect performance negatively, it seems fine for this one to get a code review and land as is! We could do a few improvements in the nitpick category, though. It'd be nice to add this new keyboard shortcut to the shortcuts sheet, this one: It also seems like we should have an icon for posts. I don't really love the "Pin" for posts, even if it has historically been represented that way. Nevertheless we do have a pin icon in the library: We could also, in the name of post types, use the same general pattern, and do this: None of those icons are published yet, but we probably want them. Let me know if you want the vectors to add to the library. |
8 tasks
|
I wish I'd get notified for thumbs up 😅 — sorry for the delay. Here are new icons: #39139 |
draganescu
force-pushed
the
try/link-autocompleter
branch
from
dac258c to
9669af2
Compare
|
Added the new icon and the shortcut in the help modal. Something I tried and failed is to timeout the sending of requests but for some reason using |
jasmussen
approved these changes
Mar 2, 2022
There was a problem hiding this comment.
Giving tentative approval to this one because:
- It's a fun power user feature that is likely to make a few people very happy
- It does not add any UI weight virtualy at all since it's likely to be rare people intentionally type
[[for typographic reasons
It also works well:
One small thing, the keyboard shortcut help looks good (see the bottom):
But shouldn't it be under "Block shortcuts"? Perhaps right under the slash command since its behavior is somewhat similar? I know the command isn't block level so it's a stretch. But it works in a block? Alternately we could rename the "Text formatting" to be "Text formatting & shortcuts"?
It'd also be nice to get another code sanity check, but otherwise: nice one!
|
@jasmussen thanks for the 👍🏻 The shortcut is very related to the link formatters so I'd leave it under "Text formatting", but move it up next to the other link format shortcuts. |
draganescu
force-pushed
the
try/link-autocompleter
branch
from
f6d927c to
5cdfca5
Compare
|
I just want to say that I deeply appreciate this feature, which I just discovered with Gutenberg 12.8. I had been futzing with various plugins that did a poor job of this sort of thing. I think you'll be very surprised at how many non-"power users" will love this as well! Thanks again! Edit: One point of feedback - it appears to work for CPTs, but not for bbPress Forums, Discussions or Replies, despite the fact that they are also CPTs. Is that something that could be investigated/added? I could see it being very useful. Perhaps a setting somewhere to allow us to select which CPTs can be autolinked? |
|
Just a thought: why not using |
|
@westonruter the editor also uses |
|
@westonruter The I'm ultimately indifferent to what is used, so long as it is functional. My concern would be confusion since, as @Mamaduka says, @ is already used for user autocompletion.
|
|
Test cases all seem to work. Thumbs up to adding the ability to link to categories and tags |
This was referenced Apr 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the block editor we currently have the
/inserter which is an autocompleter for blocks. This PR adds a new autcompleter triggered by[[with links to existing posts and pages.How has this been tested?
For now tested manually.
Screenshots
double.bracket.mp4
Types of changes
Non breaking change. Adds a new autocompleter to the
block-editorpackage.Checklist: