Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Separator: Trial custom separator height with independent top/bottom margins #28688

Closed
wants to merge 7 commits into from
Closed

[WIP] Separator: Trial custom separator height with independent top/bottom margins #28688

wants to merge 7 commits into from

Commits on Feb 3, 2021

  1. Trial splitting separator margins top/bottom

    @aaronrobertshaw
    aaronrobertshaw committed Feb 3, 2021
    Configuration menu
    Copy the full SHA
    d0f2889 View commit details
    Browse the repository at this point in the history

Commits on Feb 4, 2021

  1. Update native separator controls for split margins

    @aaronrobertshaw
    aaronrobertshaw committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    d3d58e0 View commit details
    Browse the repository at this point in the history

Commits on Feb 10, 2021

  1. Assign min height to allow immediate drag resizing

    @aaronrobertshaw
    aaronrobertshaw committed Feb 10, 2021
    Configuration menu
    Copy the full SHA
    e319fde View commit details
    Browse the repository at this point in the history

Commits on Feb 11, 2021

  1. Update margins on box resizing 

    When dev tools is open this is pretty jumpy but others feels smooth enough.
    @aaronrobertshaw
    aaronrobertshaw committed Feb 11, 2021
    Configuration menu
    Copy the full SHA
    4fc3c47 View commit details
    Browse the repository at this point in the history

  2. Unify min margins to simplify PR and refactor 

    - Adjusts margin minimums so they are the same regardless of block style
  such as Dots.
- Refactored edit component moving helpers into shared file to clean up
    @aaronrobertshaw
    aaronrobertshaw committed Feb 11, 2021
    Configuration menu
    Copy the full SHA
    1bd4f2d View commit details
    Browse the repository at this point in the history

Commits on Mar 1, 2021

  1. Fix issue switching units and setting defaults via native unit controls

    @aaronrobertshaw
    aaronrobertshaw committed Mar 1, 2021
    Configuration menu
    Copy the full SHA
    f0d5a9f View commit details
    Browse the repository at this point in the history

Commits on Mar 2, 2021

  1. Cleanup onUnitChange and remove obsolete comment

    @aaronrobertshaw
    aaronrobertshaw committed Mar 2, 2021
    Configuration menu
    Copy the full SHA
    4642393 View commit details
    Browse the repository at this point in the history