theme.json docs: fix codetabs in use #28655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oandregal
requested review from
ajitbohra,
chrisvanpatten and
mkaz
as code owners
oandregal
added
[Type] Bug
|
Going to merge this one quickly to see if I can fix it. Otherwise, I'll revert the use of |
|
Size Change: 0 B Total Size: 1.37 MB ℹ️ View Unchanged
|
|
Nice, it worked:
|
oandregal
added
the
Global Styles
oandregal
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The block editor handbook uses
codetabsas a mechanism to provide ESNext/ES5 code comparisons. Example:In https://github.com/WordPress/gutenberg/pull/28639/files/09aaa04982cadc90e044c27a8915be927a85e089#r568052600 I pushed a change that used it to illustrate a similar situation: input (theme.json) / output (CSS). It didn't work that well:
I haven't found any missing markup, so I thought I'd push a change that uses a single work in the tab ("Input" instead of "Input: theme.json" / "Output" instead of "Output: css"). Not sure if the colon or spaces is why the parser broke.