Don't add default-custom-properties styles to all compiled files #28395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -21.8 kB (-2%) Total Size: 1.37 MB
ℹ️ View Unchanged
|
gziolo
added
[Type] Performance
gziolo
reviewed
Jan 21, 2021
|
Examining the compiled files in |
gziolo
approved these changes
Jan 21, 2021
6 tasks
|
Thank you for fixing this,
With the pull request applied:
|
|
Pushed an additional commit to make sure only the |
|
Tested with an FSE theme and a non-FSE. Looked in all scss files for the admin-scheme vars and they are only used for editor styles. The vars are properly defined in the editor and removed on the frontend. |
|
I think this one regressed color themes inside the editing canvas. Say you pick "Midnight" as color theme, the focus style for selected blocks should be red. But it's now WordPress blue. |
|
Specifically, these two CSS variables are no longer available for content inside the editing canvas: |
|
Checking and will submit a follow-up PR 👍 |
|
Happy to help test. Not urgent since it's scheduled for 9.9, but would be good to fix before then. |
aristath
added a commit
that referenced
this pull request
Jan 25, 2021
See comment on #28395 (comment)
6 tasks
aristath
added a commit
that referenced
this pull request
Jan 27, 2021
See comment on #28395 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #27663
After we split compiling of block-styles in #25220 we noticed that some styles get duplicated in all blocks.
This PR fixes the issue by correcting where the
default-custom-propertiesget included.Checklist: