Remove new navigation block features in the navigation editor #28378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… features on the nav screen
talldan
added
[Type] Enhancement
talldan
requested review from
adamziel,
draganescu,
kevin940726,
noisysocks and
tellthemachines
as code owners
|
Size Change: -20 B (0%) Total Size: 1.4 MB
ℹ️ View Unchanged
|
draganescu
approved these changes
Jan 22, 2021
talldan
changed the title
|
Don't know what I was thinking when I wrote that PR title originally, updated it now. Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Over the last few months, a few extra features have been added to the navigation block. Typography options, and variations. Neither of these are or can be supported in the Navigation Editor, as WordPress menus don't support these options.
Previously the code
omitted these unsupported options, but I think there are so many now that it's better to over them.How has this been tested?
1 Visit the navigation screen
2. Typography and transformations should not be visible
Screenshots
Types of changes
(Un-)Enhancement
Checklist: