Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Content overflowing outside the container in the verse block #2835

Merged

Conversation

Nikschavan
Copy link
Contributor

@Nikschavan Nikschavan commented Sep 29, 2017

Description

This adds overflow: auto CSS property to the verse block so that the content does not overflow the block container.

How Has This Been Tested?

Tested on Chrome (61.0.3163.100) on MacOS High Sierra.

Screenshots (jpeg or gifs if applicable):

image

Types of changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows has proper inline documentation.

@youknowriad
Copy link
Contributor

Thanks for fixing this. This looks good to me.
Any design thoughts on this? is this an acceptable tradeoff @jasmussen

@jasmussen
Copy link
Contributor

Scrollbars aren't pretty, but I agree this seems like the most true to the block implementation. The alternative would make it no longer really be a verse block, wouldn't it? So 👍 👍 from me.

@youknowriad youknowriad merged commit db507cd into WordPress:master Sep 29, 2017
@Nikschavan Nikschavan deleted the fix/2821-verse-block-text-overflow branch September 29, 2017 10:41
@designsimply designsimply added the [Feature] Blocks Overall functionality of blocks label Jul 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Blocks Overall functionality of blocks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants