Site Editor: Add template part missing state #28277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
david-szabo97
added
[Feature] Full Site Editing
[Block] Template Part
david-szabo97
requested review from
mattwiebe,
youknowriad,
aristath,
vindl,
Copons,
jeyip,
noahtallen and
Addison-Stavlo
|
Size Change: +438 B (0%) Total Size: 1.28 MB
ℹ️ View Unchanged
|
youknowriad
approved these changes
Jan 18, 2021
mattwiebe
approved these changes
Jan 18, 2021
vindl
reviewed
Jan 18, 2021
Created a PR to fix it in the Warning component: #28316 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If a template part has been deleted or unavailable for some reason, we had a spinner loading infinitely. Added a
missingstate to the block to be more user friendly.NOTE: We have a regression that doesn't show the spinner. So if you test on master right now, then you will only see an empty template part block with no spinner. If you checkout to this branch you will see the warning.
How has this been tested?
Screenshots
Types of changes
New feature (non-breaking change which adds functionality)
Checklist: