Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation: Fix pointer events for invalid block warning #2811

Merged
merged 1 commit into from
Sep 27, 2017

Conversation

aduth
Copy link
Member

@aduth aduth commented Sep 27, 2017

Related: #2807
Regression introduced in #2618

This pull request seeks to resolve an issue where it is not possible to click buttons within the block validation warning. This regressed in #2618 with moving the warning into the invalid block.

https://github.com/WordPress/gutenberg/pull/2618/files#diff-5cb891cd3125ad3b221777433a61a524

The style should only apply to the preview, not the warning.

Testing instructions:

Verify that you can use buttons within the invalid block warning.

@aduth aduth requested a review from youknowriad September 27, 2017 15:31
Copy link
Contributor

@youknowriad youknowriad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ship it 👍

@aduth aduth merged commit e859601 into master Sep 27, 2017
@aduth aduth deleted the fix/block-warning-pointer-events branch September 27, 2017 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants