-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use serif system font stack for the editor content #2798
Conversation
Gosh I'm going to miss Noto Serif. Such a pretty font, and really added character to the base stylesheet (that was intended to be overridden by theme stylesheets). Visually this isn't as pretty. However if @hugobaeta in particular is on board, and if this will make people happy with the speed bump and lack of external resources, then I am okay with this! Thanks for working on it. @karmatosed @mtias any final words? |
Yeah, I don't like Georgia either. 🤷♀️ |
I personally don't like this switch much. I feel serif's as system fonts are not that well handled. If we really want to drop Noto for weight/performance, I'm kind of ok with just using sans-serif system fonts for the editor content as well. Many good editors use a sans-serif by default. |
Alternatively we could make a better serif system font stack, similar to the sans serif and monospace stack. E.g. Apple ships some slightly more decent fonts like Palatino and Hoefler Text. Windows list: https://en.wikipedia.org/wiki/List_of_typefaces_included_with_Microsoft_Windows |
I personally quite like Georgia (regular). It's Georgia bold weight I have a problem with. Maybe we could use a mixed stack for headings and paragraphs. I don't have a lot of bandwidth this week to experiment tho. But next week I could give this a try. That said, after a little bit of thought, I'm kinda ok with what @mtias suggests, just using the sans system fonts. Maybe what needs to change is how editor styles are taken from themes - could we programmatically extract typeface rules form the active theme style.css (if a editor.css doesn't exist)? Then the fallback would matter less... |
+1 to system serif |
How do people feel about Palatino? In that case it would be something like: font-family: Palatino, "Palatino Linotype", "Palatino LT STD", "Book Antiqua", Georgia, serif; Personally I'd prefer Hoefler Text on macOS, but there's nothing similar on other OSs and we'd have to adjust line heights etc. if we combine. 😔 I don't find Palatino that interesting, but it's ok. I agree with @hugobaeta about the Georgia bold, but even if we choose something else for headings (2 stacks we need to make), there's still bold through the strong tag? Maybe not as irritating. Georgia is the closest to Noto. Unless anyone finds another stack, we'll have to work with these options, or use sans serif. 😶 |
Oh, btw, Safari Reader (the distraction free mode in Safari), uses Georgia too. |
What shall we do here? |
I think Georgia works. |
Noto: Georgia: Let's walk through the pros and cons of switching to Georgia over Noto. Pros:
Cons:
I really like Noto, as it feels very "WordPress brand compatible". But I also appreciate the flipside of the coin. If we switch to Georgia I'll take a stab adjusting font-sizes and line-heights to look their best, if need be. |
Could we see what Georgia looks like in a PR, I think that would be a solid step?
The above is a bit of a concern I admit. |
As we closed this issue, lets close the PR. |
Description
See #2782. This PR sets the default font to local serif fonts (just like the current WP editor).
In addition it removes Noto from the docs, as Noto is not even loaded there.