Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve documentation for withNotices HOC in components package #27863

Merged
merged 1 commit into from
Dec 24, 2020
Merged

Improve documentation for withNotices HOC in components package #27863

merged 1 commit into from
Dec 24, 2020

Conversation

hsingyuc
Copy link
Contributor

Description

Fix #27091
Improve documentation for withNotices HOC in components package

Types of changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Dec 22, 2020
youknowriad
youknowriad approved these changes Dec 24, 2020
View reviewed changes
Copy link
Contributor

@youknowriad youknowriad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice documentation Thanks.

@youknowriad youknowriad added the [Type] Developer Documentation Documentation for developers label Dec 24, 2020
@youknowriad youknowriad merged commit d074ed1 into WordPress:master Dec 24, 2020
@github-actions github-actions bot added this to the Gutenberg 9.7 milestone Dec 24, 2020
@hsingyuc
Copy link
Contributor Author

Thanks!

@hsingyuc hsingyuc deleted the fix/27091 branch December 25, 2020 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youknowriad youknowriad youknowriad approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra

@chrisvanpatten chrisvanpatten Awaiting requested review from chrisvanpatten

Assignees
No one assigned
Labels
First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository [Type] Developer Documentation Documentation for developers
Projects
None yet
Milestone
Gutenberg 9.7
Development

Successfully merging this pull request may close these issues.

Improve documentation for withNotices HOC in components package
2 participants
@hsingyuc @youknowriad