Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CSS Reset #27518

Closed
wants to merge 1 commit into from
Closed

Add CSS Reset #27518

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions packages/block-library/src/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,3 +108,14 @@
.aligncenter {
clear: both;
}

// This resets the WordPress default
img {
height: auto;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a note for the height:auto here.
In the twentytwentyone theme this was causing a layout shift while the page was loading on slow connections. In order to fix that we had to add inline styles for the featured images (see https://github.com/WordPress/twentytwentyone/pull/692/files).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aristath Should that fix be baked into core then, and not just into this CSS reset?

If I recall correctly, this rule only became necessary after lazy loading images launched.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it became an issue after lazy-loading.
That function does the following:

  • Gets the image width & height
  • Calculates the aspect-ratio
  • Adds width:100%;height:X% (X calculated from the aspect-ratio) to the image inline.

If width:100% is OK for all themes, then we can definitely port the fix to core, but I don't think all themes will want that...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah ok, I see what you mean — a 100% width would probably cause its own set of problems in some themes. 😄

But a global fix of some kind seems to be a good idea.

max-width: 100%;
}

pre {
white-space: pre-wrap;
overflow-wrap: break-word;
}
5 changes: 5 additions & 0 deletions packages/edit-post/src/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,11 @@ body.block-editor-page {
iframe {
width: 100%;
}

pre {
white-space: pre-wrap;
overflow-wrap: break-word;
}
}

@include default-block-widths();
Expand Down