-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ESLint Plugin: Enable import rules used in Gutenberg #27387
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size Change: 0 B Total Size: 1.28 MB ℹ️ View Unchanged
|
cbc64f9
to
2f78b0b
Compare
ab0ae55
to
83a1c7b
Compare
83a1c7b
to
1081fef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Tool] ESLint plugin
/packages/eslint-plugin
[Tool] WP Scripts
/packages/scripts
[Type] Breaking Change
For PRs that introduce a change that will break existing functionality
[Type] New API
New API to be used by plugin developers or package users.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follow-up for #20905.
Fixes #15876.
This PR enables 2 ESLint rules from
esling-import-plugin
that ensure that dependencies used in the project are installed in thenode_modules
folder and listed as the project's dependencies.How has this been tested?
Types of changes
It might be a breaking change for the
@wordpress/eslint-plugin
. Users will see errors reported when using the recommended ruleset.Checklist: