Editor styles: convert to hook #27080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellatrix
requested review from
adamziel,
draganescu,
kevin940726,
noisysocks,
talldan and
tellthemachines
as code owners
|
Size Change: +29 B (0%) Total Size: 1.2 MB
ℹ️ View Unchanged
|
kevin940726
reviewed
Nov 19, 2020
6 tasks
ellatrix
force-pushed
the
try/editor-styles-hook
branch
from
1d5bc69 to
c06b908
Compare
kevin940726
approved these changes
Nov 25, 2020
|
Looks like something went wrong after the rebase. |
youknowriad
reviewed
Jan 1, 2021
| @@ -163,6 +164,9 @@ function Layout() { | |||
| }, | |||
| [ entitiesSavedStatesCallback ] | |||
| ); | |||
| const ref = useRef(); | |||
|
|
|||
| useEditorStyles( ref, settings.styles ); | |||
There was a problem hiding this comment.
Looks like this broke the "use theme editor styles" option, it's now always using the theme styles.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR converts the current unstable
EditorStylescomponent to a hook. It just needs access to a ref to know the owner document.How has this been tested?
Screenshots
Types of changes
Checklist: