Fix: Preset colors don't work on button block style outline #26707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgefilipecosta
added
[Type] Bug
jorgefilipecosta
requested review from
ajitbohra,
Soean and
talldan
as code owners
|
Size Change: +13 B (0%) Total Size: 1.21 MB
ℹ️ View Unchanged
|
|
Hey @jorgefilipecosta, just wondering if you could have linked to the wrong issue? #24625 seems to refer exclusively to text colour, and I am unable to reproduce it on either 5.5.3 or the latest master. I can see the background color not working on Twenty Twenty One, but that seems to be due to theme-specific styles as it's working fine on Twenty Twenty and Twenty Nineteen. |
|
Hi @tellthemachines, This PR addresses text color referred in #24625 and also the background color not referred there. It is a fact that on some themes this works correctly but that happens because "Twenty Twenty" and "Twenty Nineteen" used styles with higher specificity for colors. |
tellthemachines
approved these changes
Nov 6, 2020
There was a problem hiding this comment.
Oooh, I see, that makes sense! Approving ✅
Testing this branch, background color still doesn't show in Twenty Twenty One, but it seems to be caused by the theme styles. Might be worth opening an issue there?
tellthemachines
added
the
Backport to WP 6.7 Beta/RC
|
Hi, Please do not use a specific text color. Instead of Also, I don't think it is needed to address the I'd say #24626 should be sufficient enough for this case. Regards, Oliver |
jorgefilipecosta
force-pushed
the
fix/preset-colors-dont-work-on-button-block-outline-styles
branch
from
3a7ab12
to
fc7d557
Compare
jorgefilipecosta
deleted the
fix/preset-colors-dont-work-on-button-block-outline-styles
branch
|
Hi @webmandesign, On #24626 (comment) I wrote a comment detailing the path we are following for now. Thank you for raising and fixing the text color issue 👍 |
tellthemachines
pushed a commit
that referenced
this pull request
Nov 11, 2020
6 tasks
tellthemachines
added a commit
that referenced
this pull request
Nov 12, 2020
* Cover block: Restore default overlay background (#26569) * Restore default Cover overlay background The default Cover block overlay background was removed. This changed the style of existing blocks on existing sites. Restore the default background in such a way that it does not conflict with theme-provided background-color styles and there is no need to artificially add extra specificity. Fix regression: #26545 * Limit the interface skeleton to a max width of 100% to prevent some blocks managing to exceed the width (#26552) * Cover Block: Restore opacity controls (#26625) * Fix image block centering when resizing to a smaller size (#26376) * Fix image block centering when resizing to a smaller size * Revert previous 100% width fix * Remove display: table when image block is resized to avoid centering of block * Match frontend classes for alignment in editor * Gallery: Remove caption fallback for alt attribute (#26676) * Fix quote block default alignment (#26680) * Gallery: Remove obsolete deprecation entry (#26736) * Do not apply text color if it is being overriden (#24626) * Fix: Preset colors don't work on button block style outline (#26707) * Tests: Add fixture for Column deprecation (#26774) * Fix/column width units (#26757) * Fix issues with different units in column widths * Columns with fixed width should keep width on recalculation * Address review feedback * fix undefined index notice in Social Link Block (#25663) * fix undefined index notice * use isset instead of array_key_exists check * Update packages/block-library/src/social-link/index.php Co-authored-by: Greg Ziółkowski <grzegorz@gziolo.pl> Co-authored-by: Greg Ziółkowski <grzegorz@gziolo.pl> * Adds in missing styling for toolbar when using text-only setting (#26769) * Adds in missing styling for toolbar when using text-only setting * Increases margin * Moves style to correct file * Inserter: Fix 'Browse All' in Quick Inserter (#26443) * Inserter: Fix 'Browse All' in Quick Inserter Maintain the insertion point in @wordpress/block-editor state when moving from the Quick Inserter to the Inserter. This fixes a bug where the insertion point is wrong after clicking a block appender and selecting 'Browse All'. Care is taken to not regress a previous bug where the insertion point is wrong after clicking an inline insertion button and selecting 'Browse ALl'. * Inserter: Fix typo Co-authored-by: Daniel Richards <daniel.richards@automattic.com> * Call getBlockInsertionPoint once * Add useSelect dependencies * Make setInsertionPoint unstable * Avoid setting `isVisible` state when `SET_INSERTION_POINT` is triggered * Make index required and clarify rootClientId usage * Split insertionPoint into two reducers * Fix getInsertionPoint selector that expects default state of reducer to be null * Avoid resetting insertionPoint state on HIDE_INSERTION_POINT Co-authored-by: Daniel Richards <daniel.richards@automattic.com> Co-authored-by: Jon Surrell <jon.surrell@automattic.com> Co-authored-by: Jacopo Tomasone <Copons@users.noreply.github.com> Co-authored-by: Daniel Richards <daniel.richards@automattic.com> Co-authored-by: Bernie Reiter <ockham@raz.or.at> Co-authored-by: Greg Ziółkowski <grzegorz@gziolo.pl> Co-authored-by: Oliver Juhas <webmandesign@users.noreply.github.com> Co-authored-by: Jorge Costa <jorge.costa@automattic.com> Co-authored-by: Fabian Kägy <mail@fabian-kaegy.de> Co-authored-by: Tammie Lister <tammie@automattic.com> Co-authored-by: Robert Anderson <robert@noisysocks.com>
tellthemachines
removed
the
Backport to WP 6.7 Beta/RC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #24625
How has this been tested?
I added a buttons block.
I set the style of the button to outline.
I added a preset background color and a preset text color.
I published the post and verified on the frontend of the website the colors appear as expected. (on master they don't appear).