Site Editor: restore block inserter previews #26583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The fix in WordPress#26432 accidentally broke block previews in the Inserter due to a naïve use of `overflow: hidden` to fix the overscroll with the block library open in the site editor A little testing revealed that the `.components-visually-hidden` element inside `.block-editor-inserter__tips` might be at the root of causing a browser bug due to its odd combination of styles. Trusty `position: relative` stabilized the rendering context and there was once again peace in the land.
mattwiebe
requested review from
david-szabo97,
vindl,
Addison-Stavlo and
Copons
mattwiebe
added
[Feature] Full Site Editing
[Type] Bug
Addison-Stavlo
approved these changes
Oct 29, 2020
desrosj
added a commit
that referenced
this pull request
Feb 16, 2021
tellthemachines
added a commit
that referenced
this pull request
Feb 17, 2021
* Backport #26475 for the 5.6 branch. * Backport #28604. * Revert "Backport #28604." This reverts commit 32784b6. * Backport #26583 to the 5.6 branch. * Commit lock file updates. * Committing lock file differences after updating `browserslist`. * Pin the version of NodeJS in the Compressed Size workflow. * Memoize getEntityRecords to prevent infinite re-renders (#26447) * Fix issue where gallery block requests all attachments when empty (#28621) * Return early from building attachments for galleries * Improve code clarity * Fix link control styles to prevent scrollbar (#27777) * Update package-lock * Update package-lock again Co-authored-by: Jonathan Desrosiers <desrosj@users.noreply.github.com> Co-authored-by: Kai Hao <kevin830726@gmail.com> Co-authored-by: Daniel Richards <daniel.richards@automattic.com> Co-authored-by: Aaron Robertshaw <60436221+aaronrobertshaw@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The fix in #26432 accidentally broke block previews in the Inserter due to a naïve use of
overflow: hiddento fix the overscroll with the block library open in the site editor.A little testing revealed that the
.components-visually-hiddenelement inside.block-editor-inserter__tipsmight be at the root of causing a browser bug due to its odd combination of styles. Trustyposition: relativestabilized the rendering context and there was once again peace in the land.How has this been tested?
Ensuring block previews appear again when hovering over a block in the block library
Types of changes
Bug fix