Remove myself from the code owners #26413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
the
[Type] Project Management
|
Size Change: 0 B Total Size: 1.2 MB ℹ️ View Unchanged
|
gziolo
approved these changes
Oct 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you add yourself to the code owners of a given area/package, people creating PRs will get the expectations that you'll review their PRs because they see your name on the reviewers list and they don't ping people for reviews explicitly because of that.
The problem is that personally as I received a lot of pings because of that and I choose what to pay attention to so I unsubscribe from most of these leaving those folks without a notice about that.
I also noticed that most of the code owners don't really review PRs or at very rare occasions.
For these reasons, I do think the code owners is a failure experiment and that it's harming the project more than doing good. Explicit review requests instead are better.
I'll probably propose its removal in the next weeks but at least for the moment, I'm removing myself from this list to avoid to the implicit requests. If you want me to check something, add me as a reviewer or ping me.