Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed label position top & bottom were not working in SelectControl. #26390

Closed

Conversation

nirbhay18
Copy link

Description

labelPosition prop was not working in SelectControl due to CSS not being rendered.

To fix this issue I have added ${ rootLabelPositionStyles } to BaseLabel Styled Component in components/src/input-control/styles/input-control-styles.js.

How has this been tested?

  1. Create a custom block with the SelectControl component.
  2. Supply labelPostion prop with value bottom.
  3. You'll notice that the label position remains unchanged.

Screenshots

Before
image

After
image

Types of changes

Bug fix

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

@nirbhay18
Copy link
Author

The issue is persistent in the latest version of WordPress 5.5.1 running without Gutenberg Plugin but it seems to be fixed in the latest version of Gutenberg. Hence, it seems that the fix will be rolled out soon in the core version of WordPress too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant