Fix gallery block undo issue #26377
Merged
Fix gallery block undo issue #26377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talldan
added
[Type] Bug
talldan
requested review from
ellatrix,
mkevins and
youknowriad
as code owners
|
Size Change: +20 B (0%) Total Size: 1.2 MB
ℹ️ View Unchanged
|
talldan
added
the
Backport to WP 6.7 Beta/RC
This was referenced Oct 22, 2020
Closed
tellthemachines
approved these changes
Oct 23, 2020
|
The e2e test failure is unrelated to this PR, isn't it? We should be good to merge anyway? |
|
@tellthemachines Let me try a rebase, I know some tests have been fixed recently. |
talldan
force-pushed
the
fix/gallery-undo-issue
branch
from
0c90398
to
1c2b155
Compare
|
Hmm, that didn't go well, more failing than there was previously. I see there's a package-lock.json change so I'll have to commit that to master first (#26439). |
talldan
force-pushed
the
fix/gallery-undo-issue
branch
2 times, most recently
from
3c7c791
to
6dac7bb
Compare
talldan
force-pushed
the
fix/gallery-undo-issue
branch
from
6dac7bb
to
b4027ca
Compare
talldan
added a commit
that referenced
this pull request
Oct 27, 2020
* Mark change in attributes when gallery mounts as not persistant * Fix typo
6 tasks
tellthemachines
added a commit
that referenced
this pull request
Oct 27, 2020
* Fix drop zone indicators for non blocks (#25986) * Remove isDraggingBlocks check * Clean up drag and drop data if the user presses escape when dragging * Add comment to ensure avoidance of dragend * Switch to using dragend * Fix archives block render function (#26309) * Code block: preserve indentation on paste (#26347) * Turn off autocomplete for token input. (#26427) * Fix parent post selector: ensure initial value available, search performed, all results shown. (#26397) Co-authored-by: Nik Tsekouras <ntsekouras@outlook.com> * [RNMobile] Fix CI issues during `npm ci` (#26455) * Run mobile tests on master * Debug CI * Revert "Debug CI" This reverts commit dec1ebe. * Update react-native-screens ref, pin @react-navigation/native version * Pin @react-navigation/core,router versions * Fix composer test failures due to invalid lock (#26472) * Fix gallery block undo issue (#26377) * Mark change in attributes when gallery mounts as not persistant * Fix typo * Fix package lock changes * Fix some Twenty Twenty One related e2e test failures (#26341) * Account for unknown number of controls in block inspector * Ensure selection is on-screen by using a group block instead of cover, which takes up less space on screen * Fix typewriter test * Use correct name for patterns test * Revert change to .wp-env.json * Fix multi-entity side editor saving test * Remove blank line * insert paragraph instead of tempalte part (#26371) * Fix autosave e2e tests (#26416) * Update how block to render is tracked (#26356) Co-authored-by: Daniel Richards <daniel.richards@automattic.com> Co-authored-by: Riad Benguella <benguella@gmail.com> Co-authored-by: Ella van Durpe <wp@iseulde.com> Co-authored-by: Adam Silverstein <adamsilverstein@earthboundhosting.com> Co-authored-by: Nik Tsekouras <ntsekouras@outlook.com> Co-authored-by: Ceyhun Ozugur <ceyhunozugur@gmail.com> Co-authored-by: Marcus Kazmierczak <marcus@mkaz.com> Co-authored-by: Addison Stavlo <Stavz01@gmail.com> Co-authored-by: O André <nosolosw@users.noreply.github.com>
youknowriad
removed
the
Backport to WP 6.7 Beta/RC
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #26367
Part of #8119
When a gallery block is added it runs some logic to make sure the
linkToattribute is set correctly.This seems to cause an undo state which the user can't click past.
Elsewhere in the gallery block
__unstableMarkNextChangeAsNotPersistentis used to prevent this, so I've used it again here.How has this been tested?
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist: