Add types to style mixins #26369
Closed
Add types to style mixins #26369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarayourfriend
requested review from
ajitbohra,
chrisvanpatten and
youknowriad
as code owners
sarayourfriend
commented
Oct 21, 2020
| @@ -60,7 +67,10 @@ function useControlledState( currentState, options = defaultOptions ) { | |||
| fallback | |||
| ); | |||
|
|
|||
| const setState = ( nextState ) => { | |||
| const setState = ( | |||
| /** @type {any} */ | |||
There was a problem hiding this comment.
The template T isn't in scope here 😕
sarayourfriend
commented
Oct 21, 2020
| @@ -29,7 +29,10 @@ function useJumpStep( { | |||
| const [ isShiftKey, setIsShiftKey ] = useState( false ); | |||
|
|
|||
| useEffect( () => { | |||
| const handleShiftKeyToggle = ( event ) => { | |||
| const handleShiftKeyToggle = ( | |||
| /** @type {KeyboardEvent} */ | |||
There was a problem hiding this comment.
This get's passed to window.addEventListener so we do not use the synthetic version from react
sarayourfriend
commented
Oct 21, 2020
| * | ||
| * @return {number} The sum of values. | ||
| */ | ||
| export function add( ...args ) { | ||
| return args.reduce( ( sum, arg ) => sum + getNumber( arg ), 0 ); | ||
| return args.map( getNumber ).reduce( ( sum, arg ) => sum + arg, 0 ); |
There was a problem hiding this comment.
This and the change below should be equivalent in runtime but appeases the typechecking (I couldn't figure out how to communicate to TS through JSDoc that reduce was going to be called as reduce<string|number, number>. It insisted that the return type of reduce be string|number. Mapping the array to number from string|number first avoids this. From a performance perspective I think this is negligible (you'd only start to notice if we were adding several thousand numbers, right?)
|
Size Change: +41 B (0%) Total Size: 1.2 MB
ℹ️ View Unchanged
|
6 tasks
|
This is exciting ❤️ ! Would love to see what others think. My TS knowledge doesn't extend this far 🙈 - to be specific, typing things purely with TSDoc/JSDoc |
|
Closing as duplicate of #26078 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds/corrects types to the style mixins.
How has this been tested?
Typecheck run and usages confirmed.
Types of changes
New/updated types.
Checklist:
Blocks #26366