Movers: Small positioning refactor. #26353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasmussen
added
the
[Type] Code Quality
|
Size Change: -16 B (0%) Total Size: 1.21 MB
ℹ️ View Unchanged
|
jasmussen
force-pushed
the
try/refactor-movers
branch
3 times, most recently
from
5a84ec8 to
6a4b345
Compare
jasmussen
force-pushed
the
try/refactor-movers
branch
from
6a4b345 to
c955ce5
Compare
|
🚀🚀 |
jasmussen
added a commit
that referenced
this pull request
Nov 6, 2020
Regressed in #26353. This fixes it.
jasmussen
added a commit
that referenced
this pull request
Nov 6, 2020
Regressed in #26353. This fixes it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the CSS for positioning the arrow SVGs inside the mover buttons.
In testing this PR, you should ideally not see any difference before and after. But there are some special instances, and I haven't narrowed down exactly what makes this happen, the mover arrows get offset by 1 pixel, probably due to browser rounding issues.
The CSS refactor in this PR should make that a thing of the past.
Before (in some rare cases):
After:
Gif comparing the two
