Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding spacing between navigation group components, fixing height for… #26337

Closed
wants to merge 0 commits into from

Conversation

joelclimbsthings
Copy link
Contributor

@joelclimbsthings joelclimbsthings commented Oct 20, 2020

Fixes #26336

The design for the navigation component has been updated to require a few minor CSS updates; including:

  • The individual items should have a height of 32px
  • Consecutive groups should have a 24px spacing
  • Cancelling native margin styles present in wp-admin environment

Description

Only some minor CSS additions in navigation-styles.scss that only impact the experimental navigation component.

How has this been tested?

  • Viewing the usage of the navigation component within the wc-admin environment
  • Viewing the component within Storybook
  • Running linting/tests

Screenshots

Before:

Screenshot from 2020-10-20 14-44-09

After:

after

Types of changes

Bug fix, updating to align with newer designs for experimental navigation components

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Experimental Nav Components do not match updated design
1 participant