Process settings only once in edit-site #26330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oandregal
requested review from
spacedmonkey and
TimothyBJacobs
as code owners
oandregal
added
the
Global Styles
oandregal
commented
Oct 20, 2020
| @@ -137,11 +137,6 @@ function gutenberg_edit_site_init( $hook ) { | |||
| $settings['styles'] = gutenberg_get_editor_styles(); | |||
| $settings = gutenberg_experimental_global_styles_settings( $settings ); | |||
|
|
|||
| // This is so other parts of the code can hook their own settings. | |||
There was a problem hiding this comment.
Note how in the line above this code we call gutenberg_experimental_global_styles_settings.
|
Size Change: +15 B (0%) Total Size: 1.2 MB
ℹ️ View Unchanged
|
gziolo
reviewed
Oct 20, 2020
gziolo
approved these changes
Oct 21, 2020
|
@gziolo By making sure the edit-site store still has the settings it needs: |
|
I can confirm that all those experimental settings are exposed only once in the source code of HTML document and it's propagated correctly to the block editor store :) |
oandregal
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are processing Global Styles twice in the edit-site screen. This PR removes the duplication and follows the same standards as in the other screens, this is, use
gutenberg_experimental_global_styles_settingsto get the settings instead of hooking into theblock_editor_settingfilter.