Ensure focus of input when InputControl spinner arrows are pressed #25753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is redundant for most browsers. Though Firefox, for example, does not focus the input when the spinners are clicked. Without focus the spinners cannot cause the component to update due to value sync logic introduced in 2d5106a
stokesman
requested review from
ajitbohra,
chrisvanpatten and
youknowriad
as code owners
|
Just saw this same effect in the sidebar of "Gutenberg Blocks – Ultimate Addons for Gutenberg" #25753 Looks like it's a general Gutenberg issue |
stokesman
changed the title
|
@Sven74Muc, thanks again for the initial report and yes, the issue could be present in quite a few places. Fortunately, they'll all be resolved by a fix in one place. @ItsJonQ, I thought you'd like to be aware of the issue this PR is aims to fix since it was introduced by the recent sync changes in |
ItsJonQ
approved these changes
Oct 2, 2020
There was a problem hiding this comment.
👍 from me! Thanks @stokesman . Tested locally on Safari and Firefox, and it looks like it's working 🙌
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's currently no separate issue for this. It was reported here: #25528 (comment)
In Firefox (and maybe some other UA out there) number inputs are not focused when their spinners are pressed:
As demonstrated in the screen capture it prevents the value from updating. Without focus the spinners cannot cause the component to update due to value sync logic introduced in 2d5106a.
This PR adds a little workaround to fix the issue by adding a handler for
onmousedownwhen InputControl is of number type. The handler focuses the input in case it's not.How has this been tested?
With WordPress 5.5.1
Types of changes
bug fix
Checklist: