jest-puppeteer-axe: migrate to @axe-core/puppeteer

[Hypnosphi]

axe-puppeteer is deprecated and renamed to @axe-core/puppeteer, see https://github.com/dequelabs/axe-puppeteer#deprecated-axe-puppeteer

[Hypnosphi]

@gziolo can you please review?

[gziolo]

@Hypnosphi, I'm back from extended leave. I will have a look at this PR in the upcoming days, thanks for proposing those changes 👍

[gziolo]

One note, there are legitimate failures in e2e tests raised by the new version of axe API. The best way of moving forward would be to skip them for the time being and report a separate issue for them. We already maintain the list of disabled rules:

gutenberg/packages/e2e-tests/config/setup-test-framework.js

Lines 189 to 204 in bd45cc9

	disabledRules: [
	'aria-allowed-role',
	'aria-allowed-attr',
	'aria-hidden-focus',
	'aria-input-field-name',
	'aria-valid-attr-value',
	'button-name',
	'color-contrast',
	'dlitem',
	'duplicate-id',
	'label',
	'landmark-one-main',
	'link-name',
	'listitem',
	'region',
	],

[gziolo]

There are two things that would make this PR complete:

1. aria-required-children and aria-required-parent are two rules that need to be disabled in the check for e2e tests.
2. An entry in the CHANGELOG (https://github.com/WordPress/gutenberg/blob/master/packages/jest-puppeteer-axe/CHANGELOG.md) file describing the change would be very useful as well.

[gziolo]

I added some additional comments that should conclude this PR.

[gziolo]

There's still one e2e test failing:

FAIL packages/e2e-tests/specs/local/demo.test.js (6.605s)
29
  ● new editor state › should be immediately saveable
30

31
    expect(jest.fn()).not.toHaveErrored(expected)
32

33
    Expected mock function not to be called but it was called with:
34
    ["Failed to inject axe-core into frame (about:blank)"],["Failed to inject axe-core into frame (about:blank)"],["Failed to inject axe-core into frame (about:blank)"]
35

36
      at assertExpectedCalls (../jest-console/build/@wordpress/jest-console/src/index.js:36:4)
37
          at runMicrotasks (<anonymous>)
38

It's surprising to see it. Let me restart tests and debug locally if it doesn't help.

[gziolo]

I tested locally and I see the same e2e test failure on master branch. Let's get this in and explore it separately.

Thank you again for the patch 💯