Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tags support in Query block #25005

Merged
merged 6 commits into from
Sep 7, 2020
Merged

Add tags support in Query block #25005

merged 6 commits into from
Sep 7, 2020

Conversation

ntsekouras
Copy link
Contributor

@ntsekouras ntsekouras commented Sep 2, 2020

Description

This PR will add tags support in Query block and is part of #24934 and FSE milestone 5.

There still needs to be a decision about the final design of Query block, but that also depends on how many things we will include eventually and where ( toolbar, inspector controls etc..).

For now I've added the tags controls in the toolbar like the previously existed categories. To me though this could be a better fit for inspector controls (maybe a follow up PR?). IMO since it's easy to move the functionality between the toolbar and the inspector controls, this enhances the functionality of Query block and could be merged even without the finalized design.

Also note that for now if you select both tags and categories it defaults to AND query for those. Maybe we should consider tax relation in the future to allow the OR option.

Finally this PR fixes a previous bug which didn't allow the selection of multiple categories in Query block. The multiple terms are with OR relationship. That means if we have two categories [a, b] and one tag [tagLabel], it would fetch a+tagLabel OR b+tagLabel.
Fixes: #25047

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

@ntsekouras ntsekouras added [Feature] Themes Questions or issues with incorporating or styling blocks in a theme. [Feature] Full Site Editing [Block] Query Loop Affects the Query Loop Block labels Sep 2, 2020
@ntsekouras ntsekouras self-assigned this Sep 2, 2020
@github-actions
Copy link

github-actions bot commented Sep 2, 2020

Size Change: +2.82 kB (0%)

Total Size: 1.2 MB

Filename Size Change
build/block-directory/index.js 8.5 kB +505 B (5%) 🔍
build/block-editor/index.js 128 kB +59 B (0%)
build/block-editor/style-rtl.css 11.1 kB +58 B (0%)
build/block-editor/style.css 11.1 kB +55 B (0%)
build/block-library/editor-rtl.css 8.64 kB +85 B (0%)
build/block-library/editor.css 8.64 kB +85 B (0%)
build/block-library/index.js 138 kB +1.69 kB (1%)
build/block-library/style-rtl.css 7.6 kB +130 B (1%)
build/block-library/style.css 7.6 kB +127 B (1%)
build/block-library/theme-rtl.css 754 B +13 B (1%)
build/block-library/theme.css 754 B +12 B (1%)
build/components/index.js 200 kB +5 B (0%)
build/core-data/index.js 12.3 kB -3 B (0%)
build/edit-site/index.js 17.1 kB +7 B (0%)
ℹ️ View Unchanged
Filename Size Change
build/a11y/index.js 1.14 kB 0 B
build/annotations/index.js 3.67 kB 0 B
build/api-fetch/index.js 3.41 kB 0 B
build/autop/index.js 2.82 kB 0 B
build/blob/index.js 620 B 0 B
build/block-directory/style-rtl.css 953 B 0 B
build/block-directory/style.css 952 B 0 B
build/block-serialization-default-parser/index.js 1.88 kB 0 B
build/block-serialization-spec-parser/index.js 3.1 kB 0 B
build/blocks/index.js 47.7 kB 0 B
build/components/style-rtl.css 15.5 kB 0 B
build/components/style.css 15.5 kB 0 B
build/compose/index.js 9.67 kB 0 B
build/data-controls/index.js 1.29 kB 0 B
build/data/index.js 8.55 kB 0 B
build/date/index.js 31.9 kB 0 B
build/deprecated/index.js 772 B 0 B
build/dom-ready/index.js 568 B 0 B
build/dom/index.js 4.48 kB 0 B
build/edit-navigation/index.js 11.7 kB 0 B
build/edit-navigation/style-rtl.css 1.16 kB 0 B
build/edit-navigation/style.css 1.16 kB 0 B
build/edit-post/index.js 305 kB 0 B
build/edit-post/style-rtl.css 6.26 kB 0 B
build/edit-post/style.css 6.25 kB 0 B
build/edit-site/style-rtl.css 3.06 kB 0 B
build/edit-site/style.css 3.06 kB 0 B
build/edit-widgets/index.js 12 kB 0 B
build/edit-widgets/style-rtl.css 2.46 kB 0 B
build/edit-widgets/style.css 2.45 kB 0 B
build/editor/editor-styles-rtl.css 492 B 0 B
build/editor/editor-styles.css 493 B 0 B
build/editor/index.js 45.6 kB 0 B
build/editor/style-rtl.css 3.81 kB 0 B
build/editor/style.css 3.81 kB 0 B
build/element/index.js 4.64 kB 0 B
build/escape-html/index.js 733 B 0 B
build/format-library/index.js 7.71 kB 0 B
build/format-library/style-rtl.css 547 B 0 B
build/format-library/style.css 548 B 0 B
build/hooks/index.js 2.13 kB 0 B
build/html-entities/index.js 622 B 0 B
build/i18n/index.js 3.57 kB 0 B
build/is-shallow-equal/index.js 711 B 0 B
build/keyboard-shortcuts/index.js 2.52 kB 0 B
build/keycodes/index.js 1.94 kB 0 B
build/list-reusable-blocks/index.js 3.12 kB 0 B
build/list-reusable-blocks/style-rtl.css 476 B 0 B
build/list-reusable-blocks/style.css 476 B 0 B
build/media-utils/index.js 5.32 kB 0 B
build/notices/index.js 1.79 kB 0 B
build/nux/index.js 3.4 kB 0 B
build/nux/style-rtl.css 671 B 0 B
build/nux/style.css 668 B 0 B
build/plugins/index.js 2.56 kB 0 B
build/primitives/index.js 1.41 kB 0 B
build/priority-queue/index.js 789 B 0 B
build/redux-routine/index.js 2.85 kB 0 B
build/rich-text/index.js 13.9 kB 0 B
build/server-side-render/index.js 2.77 kB 0 B
build/shortcode/index.js 1.7 kB 0 B
build/token-list/index.js 1.27 kB 0 B
build/url/index.js 4.06 kB 0 B
build/viewport/index.js 1.85 kB 0 B
build/warning/index.js 1.13 kB 0 B
build/wordcount/index.js 1.17 kB 0 B

compressed-size-action

lib/compat.php Outdated Show resolved Hide resolved
Copy link
Contributor

@draganescu draganescu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and read the code, LGTM!

@draganescu draganescu merged commit 9ced21b into master Sep 7, 2020
@draganescu draganescu deleted the add/query-tags-support branch September 7, 2020 13:03
@github-actions github-actions bot added this to the Gutenberg 9.0 milestone Sep 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Query Loop Affects the Query Loop Block [Feature] Themes Questions or issues with incorporating or styling blocks in a theme.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add multiple categories in Query block
2 participants