-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better inline paste #2497
Better inline paste #2497
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2497 +/- ##
==========================================
+ Coverage 27.2% 29.44% +2.23%
==========================================
Files 160 167 +7
Lines 4914 5203 +289
Branches 819 876 +57
==========================================
+ Hits 1337 1532 +195
- Misses 3030 3108 +78
- Partials 547 563 +16
Continue to review full report at Codecov.
|
I feel like it might be better to have one loop over all nodes and then apply filters on each node (except for normalising blocks). I'll explore that in a separate PR. |
38cfbed
to
a8da893
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -1,9 +1,7 @@ | |||
import * as keycodes from './keycodes'; | |||
import * as nodetypes from './nodetypes'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good! I like the imports from window.Node
better. One less piece of duplication
Fixes #2459, and inline Editable paste.
{ inline: true }
if the editable expects inline content. If so, we strip everything that is not text or inline tags.To test: