Template Part: Move "title" to block toolbar #24450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noahtallen
added
[Type] Enhancement
|
Size Change: -43 B (0%) Total Size: 1.16 MB
ℹ️ View Unchanged
|
6 tasks
jeyip
reviewed
Aug 7, 2020
There was a problem hiding this comment.
Requirements
- I can modify and persist the template part name.
- I can modify and persist the template part name at the same time as other site editor updates.
- Text changes are still cached when, without saving, the user focuses on a new block and returns focus to the original block.
Browsers
- Firefox
- Chrome
- Edge
- Safari
epiqueras
approved these changes
Aug 7, 2020
jeyip
approved these changes
Aug 7, 2020
There was a problem hiding this comment.
The changes here make sense to me. I know that you mention that "This is not supposed to be a super fancy, polished design or implementation", and that "It's just a foundation from which we can improve the interaction." I think it might warrant a quick check-in with design to make sure that this the UX pattern upon which we'd like to iterate.
With that being said, the code changes look good to me. 🚀
noahtallen
force-pushed
the
move/fse-template-part-name-to-block-title
branch
from
2b07531
to
411ced5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Moves the title input to the block toolbar for consistency. Work towards #23871.
_Note: This is not supposed to be a super fancy, polished design or implementation. It's just a foundation from which we can improve the interaction. _
This is part of our work towards the editing interactions with the different entity-related blocks in the editor, like the template parts.
How has this been tested?
Locally, in edit site.
Screenshots
Types of changes
Enhancement
Checklist: