-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spacer block: Reduce minimum height to 5px #24342
Conversation
Size Change: 0 B Total Size: 1.16 MB ℹ️ View Unchanged
|
5px is better than 20 px... but as ong as all other blocks are missing padding & margin, why not setting the spacer to a min height of 1px? |
Answered here: #18906 (comment) |
Closing as superseded by #25528, thanks Mark for the exploration on this PR. |
Description
Fixes #18906
This PR reduces the minimum height of the Spacer block to 5px instead of 20px.
There's been some feedback that a minimum height of 20px was too big and felt much like a bug. I agree it doesn't allow for the precise adjustments a user might like when building their layout. For this reason, I've created this PR to fiddle with and see if a minimum of 5px feels better. It is still selectable with the mouse albeit the click space is much smaller now. And it no longer aligns with the height of the Separator block either. But dang, I like being able to go smaller with this block! 😉
cc @designsimply
How has this been tested?
Tested locally.
Screenshots
Types of changes
Non-breaking changes.
Checklist: