-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Post Comments Block - add block alignment hook support. #24226
Post Comments Block - add block alignment hook support. #24226
Conversation
Size Change: +13 B (0%) Total Size: 1.16 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can confirm that alignments are correct in the editor and the "alignwide" and "alignfull" classnames are applied to the post comments wrapper div
in the frontend. 🌟
Note: I did see one issue. For me, on Firefox and Safari, selecting wide and full alignment doesn't seem to update anything in the block editor. The issue, however, seems unrelated to your PR because all blocks seem to be affected by this problem in those browsers.
I see the same for Chrome. It seems to work in the post-editor but not in the site editor. I believe it is because the Template has it is the child of another block that is not set to have width set (or support). In my specific case it is a Query Loop block that is being restricting (and that creates a post-content block that would need to be set to wide or full as well? 🤔 ). Similarly, If I navigate to view a specific individual post in the site editor it seems to work. |
That makes total sense. Thanks for looking into it. I see the same things, and the more I experiment, the more it all looks very unrelated to this PR. (I can set up a new GH issue if we think it's worthwhile to prioritize now) Nice job on setting us up for success with #24122 It made CR easy-breezy 🙂 +1 from me! |
Description
A minor follow-up to #24080 (now that #24122 has landed) to give the Post Comments block the
align
hook support as part of the requested feature parity.How has this been tested?
Tested on local docker environment.
Verify the Post Comments block has the options to set 'wide' and 'full' alignments in the editor.
Similarly, verify that when saved these alignments are added on the front-end:
Screenshots
Types of changes
New feature (non-breaking change which adds functionality)
Checklist: