Block Directory: Return inactive plugins in search results #23688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryelle
added
the
[Feature] Block Directory
|
Size Change: +40 B (0%) Total Size: 1.13 MB
ℹ️ View Unchanged
|
The plugin URL will only exist if the plugin is already installed, so we can use that to activate that plugin. We can also use this link for uninstallation, so we make sure to add it into the block object when installing a plugin.
ryelle
force-pushed
the
fix/block-dir-find-inactive-plugins
branch
from
8b21bd0 to
4490234
Compare
| method: 'PUT', | ||
| } ); | ||
| } else { | ||
| const response = yield apiFetch( { |
There was a problem hiding this comment.
Not necessary, but we could also use the wp:install-plugin link as a base, and just add the status: active data.
| if ( link && link.length ) { | ||
| return link[ 0 ].href; | ||
| } | ||
| return false; |
There was a problem hiding this comment.
Not incredibly important but @wordpress/url's getPath returns undefined (which we use in controls.js).
I wonder if it makes sense to follow that convention.
StevenDufresne
approved these changes
Jul 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #23570 — This skips the check in the search results endpoint that filters out installed blocks, so that installed-but-deactivated blocks are returned. Blocks that are installed will contain an extra link property in the result, which we can use in the install flow to just activate the plugin.
This also changes the uninstallation flow to use the same link property, instead of a custom endpoint property.
How has this been tested?
I updated the unit tests, and manually tested with a combination of locally installed block plugins.
From the original issue:
Types of changes
Bug fix (non-breaking change which fixes an issue)