Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Button Component - remove isLarge prop #23239

Merged
merged 2 commits into from
Jun 18, 2020
Merged

Button Component - remove isLarge prop #23239

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8223456
Button Component - remove redundant isLarge prop and class name + upd…
rmorse Jun 17, 2020
ffde2cc
Button Component - remove tests for isLarge to fix Travis build
rmorse Jun 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion packages/components/src/button/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,6 @@ Name | Type | Default | Description
`isPrimary` | `bool` | `false` | Renders a primary button style.
`isTertiary` | `bool` | `false` | Renders a text-based button style.
`isDestructive` | `bool` | `false` | Renders a red text-based button style to indicate destructive behavior.
`isLarge` | `bool` | `false` | Increases the size of the button.
`isSmall` | `bool` | `false` | Decreases the size of the button.
`isPressed` | `bool` | `false` | Renders a pressed button style.
`isBusy` | `bool` | `false` | Indicates activity while a action is being performed.
Expand Down
2 changes: 0 additions & 2 deletions packages/components/src/button/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ export function Button( props, ref ) {
href,
target,
isPrimary,
isLarge,
isSmall,
isTertiary,
isPressed,
Expand Down Expand Up @@ -54,7 +53,6 @@ export function Button( props, ref ) {
const classes = classnames( 'components-button', className, {
'is-secondary': isDefault || isSecondary,
'is-primary': isPrimary,
'is-large': isLarge,
'is-small': isSmall,
'is-tertiary': isTertiary,
'is-pressed': isPressed,
Expand Down