Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export the image editor so it can be used by plugins or themes. #23155

Closed
wants to merge 1 commit into from
Closed

Export the image editor so it can be used by plugins or themes. #23155

wants to merge 1 commit into from

Conversation

herregroen
Copy link

Description

Exports the ImageEditor so it can be used by plugins or themes.

@swissspidy
Copy link
Member

Citing #23053

In the future, if this component could be useful for other blocks and if it is ready, we can consider creating a separate component in the block editor package, maybe similar to the replace flow. Having it in the block library as a filter for a block doesn't make much sense right now.

@swissspidy swissspidy requested a review from ellatrix June 15, 2020 11:39
@jdevalk
Copy link
Contributor

jdevalk commented Jun 15, 2020

Honestly I disagree with that point of view. Now we're being blocked from using it and forced to just copy / paste the code into our own plugin.

@swissspidy
Copy link
Member

@jdevalk What I am getting from the cited statement (and what I wanted to share) is that this component should be exposed via @wordpress/block-editor, not as part of the image block in @wordpress/block-library. I don't think you'd disagree with that..?

@jdevalk
Copy link
Contributor

jdevalk commented Jun 15, 2020

Ah my apologies I completely misunderstood what you were saying then :-)

@ellatrix
Copy link
Member

ellatrix commented Jun 15, 2020

@jdevalk Could you elaborate on how you'd like to use it?

@jdevalk
Copy link
Contributor

jdevalk commented Jun 15, 2020

@jdevalk Could you elaborate on how you'd like to use it?

We have images in our HowTo and FAQ blocks, we'd like to add the same image editing options to those.

@talldan talldan added [Block] Image Affects the Image Block [Type] Task Issues or PRs that have been broken down into an individual action to take labels Jun 16, 2020
@talldan
Copy link
Contributor

talldan commented Jun 16, 2020

This PR is a bit light on info, noting that this was discussed in slack where there's some more information:
https://wordpress.slack.com/archives/C02QB2JS7/p1592219787143400

One of the considerations mentioned there is that the feature is being developed as an experiment.

It also looks like it depends on an experimental REST API endpoint that is currently only defined in the Gutenberg plugin, so that would have to be migrated to WordPress core. I think there was some discussion around allowing experimental REST API endpoints in core, but I'm not fully up-to-date on that.

@herregroen herregroen requested a review from ajlende as a code owner October 1, 2020 09:39
Base automatically changed from master to trunk March 1, 2021 15:43
@ajlende ajlende mentioned this pull request Jul 12, 2021
7 tasks
@Yoast Yoast closed this by deleting the head repository Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Image Affects the Image Block [Type] Task Issues or PRs that have been broken down into an individual action to take
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants