-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MediaPlaceholder: add onFilesPreUpload property #23003
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
retrofox
added
[Feature] Media
Anything that impacts the experience of managing media
[Type] Enhancement
A suggestion for improvement.
labels
Jun 8, 2020
Size Change: +929 B (0%) Total Size: 1.13 MB
ℹ️ View Unchanged
|
retrofox
changed the title
MediaPlacerholder: add onFilesUpload property
MediaPlaceholder: add onFilesPreUpload property
Jun 9, 2020
draganescu
approved these changes
Jun 10, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and it breaks nothing!
This was referenced Jun 24, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Feature] Media
Anything that impacts the experience of managing media
[Type] Enhancement
A suggestion for improvement.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
editor.MediaPlaceholder
filter is great! and it allows us to customize the component easily. The only thing that I think it's missing is the ability to know what are the files that are being uploaded. For this, I've created this PR.In short, you can know which files are going to be uploaded before to start the process to the server-side binding a function to the onFilesPreUpload property.
How has this been tested?
It's a small change and doesn't modify the API of the component. Testing uploading a new file for a cover block could be a nice way to test that it doesn't break the functionality of the MediaPlaceholer, either uploading the file or dropping it.
Additionally, the example above is valid for testing purposes. Bind the function to the hook and confirm that the files list appears in the dev console in your dev client. In Chrome, for instance:
Screenshots
Types of changes
Checklist: