Image block: avoid edit (history/undo) during image upload #22761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellatrix
requested review from
ajitbohra,
jorgefilipecosta,
Soean,
talldan and
youknowriad
as code owners
ellatrix
commented
May 29, 2020
| if ( options.silent ) { | ||
| const attributes = window.wp.data | ||
| .select( 'core/block-editor' ) | ||
| .getBlockAttributes( clientId ); |
There was a problem hiding this comment.
To do: move to reducer.
|
Size Change: +45 B (0%) Total Size: 1.11 MB
ℹ️ View Unchanged
|
|
I'm closing this PR because it's not a good solution. It doesn't account for edits made in-between. I'm trying to come up with something better. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Partly fixes #8119.
This tries fixed a long standing issue with the image block: undo after upload loads the temporary URL, which is no longer available. The problem is that the attributes are set twice and seen as two steps in the history.
My proposed solution is to set the attributes once, and then "silently" mutate the state when the upload is complete. The only rule for a block to silently set attributes is that there should be no difference in data or appearance. This is the case for image upload, because the temporary image should be the exact same as the image after upload.
The only conflict to this rule with the current UI is that we have some loading UI that is displayed while image is uploading to the server. I think we should get rid of this.
Timeline of image upload
How has this been tested?
Screenshots
Types of changes
Checklist: