Add dark theme colors to pullquote and quote #22451
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #16732
This pull request adds dark theme colors to pullquote and quote blocks to address visibility issues on themes that enable
dark-editor-style
. I changed the colors of the borders to ones suggested in this comment by @kjellr. I also noticed that the citation in both blocks were using dark gray and changed both to be a light gray instead.How has this been tested?
I enabled the TwentyTwenty theme and changed the background colors to enable the darkmode. I then made the code changes, verified the changes and then changed the background back to a lighter color to ensure no harm was done to the default light theme.
Screenshots
Before
After
Types of changes
Feature: Darkmode for quote and pull quote blocks
Checklist:
Follow-up issue Check color contrast and provide recommendations to meet WCAG guidelines #16826 for general color contrast