Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dark theme colors to pullquote and quote #22451

Closed
wants to merge 1 commit into from

Conversation

j-gosch
Copy link

@j-gosch j-gosch commented May 19, 2020

Description

Closes #16732

This pull request adds dark theme colors to pullquote and quote blocks to address visibility issues on themes that enable dark-editor-style. I changed the colors of the borders to ones suggested in this comment by @kjellr. I also noticed that the citation in both blocks were using dark gray and changed both to be a light gray instead.

How has this been tested?

I enabled the TwentyTwenty theme and changed the background colors to enable the darkmode. I then made the code changes, verified the changes and then changed the background back to a lighter color to ensure no harm was done to the default light theme.

Screenshots

Before
image

After
Screen Shot 2020-05-18 at 6 06 48 PM

Types of changes

Feature: Darkmode for quote and pull quote blocks

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
    Follow-up issue Check color contrast and provide recommendations to meet WCAG guidelines #16826 for general color contrast
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

Base automatically changed from master to trunk March 1, 2021 15:43
@skorasaurus skorasaurus added [Block] Pullquote Affects the Pullquote Block [Block] Quote Affects the Quote Block labels Aug 18, 2021
@t-hamano
Copy link
Contributor

Hi @j-gosch,

I apologize for being so late in confirming this PR.

This issue appears to have been resolved by #26510, so I'd like to close this PR, but I appreciate your contributions 👍

@t-hamano t-hamano closed this Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Pullquote Affects the Pullquote Block [Block] Quote Affects the Quote Block
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider revising default quote and pullquote colors in dark mode.
3 participants