-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Block patterns categories follow-up #22410
Conversation
register_block_pattern_category( 'text', array( 'label' => __( 'Text', 'gutenberg' ) ) ); | ||
register_block_pattern_category( 'hero', array( 'label' => __( 'Hero', 'gutenberg' ) ) ); | ||
register_block_pattern_category( 'text', array( 'label' => _x( 'Text', 'Block pattern category', 'gutenberg' ) ) ); | ||
register_block_pattern_category( 'hero', array( 'label' => _x( 'Hero', 'Block pattern category', 'gutenberg' ) ) ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why only add the context to these two categories? I'd add them to all for consistency.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't know whether you meant all or just these two originally. The downside is the potential string duplication. I'll update
Size Change: +1 B Total Size: 835 kB
ℹ️ View Unchanged
|
This PR addresses some follow-up issues raised after the merge of #22164
#22164 (review)
#22164 (review)
#22164 (review)