Complementary areas use isActiveByDefault prop and local storage to determine whether is active or not #22381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgefilipecosta
added
[Type] Enhancement
youknowriad
reviewed
May 15, 2020
|
|
||
| const { Slot: InspectorSlot, Fill: InspectorFill } = createSlotFill( | ||
| 'EditSiteSidebarInspector' | ||
| ); | ||
|
|
||
| const BLOCK_INSPECTOR_ACTIVE_BY_DEFAULT = Platform.select( { |
There was a problem hiding this comment.
Is this default value different between native and web or between web and web mobile?
There was a problem hiding this comment.
The difference is between native and web. We had a /packages/interface/src/store/defaults.native.js file specifying the default for native is to contain no open sidebars.
|
Size Change: -168 B (0%) Total Size: 1.12 MB
ℹ️ View Unchanged
|
jorgefilipecosta
force-pushed
the
update/remove-static-default-from-complementary-areas-enabled-areas
branch
from
7e614ab to
2514ce3
Compare
|
This PR was rebased and should be ready for a final look. |
jorgefilipecosta
deleted the
update/remove-static-default-from-complementary-areas-enabled-areas
branch
oandregal
changed the title
oandregal
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes static defaults setting which complementary areas are active (sidebars). Instead of static defaults, it proposes a flag "isActiveByDefault" that, when true, makes a complementary area active by default on the first-page load. On follow up page loads, the setting is retrieved from local storage.
cc: @youknowriad, @gziolo
How has this been tested?
I used
window.localStorage.clear();to clean the local storage.I verified on edit-post and edit-site the default state of sidebars is kept as before.
I changed sidebars and verified their state is still persisted across page loads.