Create toolbar item compatible for RN. #22232
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SergioEstevao
added
the
Mobile App - i.e. Android or iOS
2 tasks
|
Hey @SergioEstevao! Could you take a look at #22229? I don't think any of this extra stuff is really needed. |
|
Size Change: 0 B Total Size: 824 kB ℹ️ View Unchanged
|
diegohaz
reviewed
May 8, 2020
There was a problem hiding this comment.
Thanks for this, @SergioEstevao! :)
I made some comments, but I think the changes I'm suggesting here will make the code exact the same as in #22229, so it would be nice if you can check that.
| import ToolbarContext from '../toolbar-context'; | ||
|
|
||
| function ToolbarItem( { children, ...props }, ref ) { | ||
| const accessibleToolbarState = useContext( ToolbarContext ); |
There was a problem hiding this comment.
This ToolbarContext is only for the web. It handles the state of the toolbar when using arrow keys to move between toolbar items.
| return null; | ||
| } | ||
|
|
||
| const allProps = { ...props, ref, 'data-experimental-toolbar-item': true }; |
There was a problem hiding this comment.
data-experimental-toolbar-item is not needed here.
Comment on lines
+33
to
+41
| return ( | ||
| <BaseToolbarItem { ...accessibleToolbarState } { ...allProps }> | ||
| { ( htmlProps ) => | ||
| // Overwriting BaseToolbarItem's onMouseDown since it disables drag | ||
| // and drop | ||
| children( { ...htmlProps, onMouseDown: allProps.onMouseDown } ) | ||
| } | ||
| </BaseToolbarItem> | ||
| ); |
There was a problem hiding this comment.
Does this work on RN?
<View prop="value">{ ( props ) => children( props ) }</View>I would say that this is not needed at all. And the code would never reach to that point any way because accessibleToolbarState should be always falsy on RN. So return children( { ...props, ref } ) is probably all you need.
There was a problem hiding this comment.
It works, but feel free to push to the PR, with your changes, and I can test it.
|
Closed in favor of #22229 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix breakage in RN-mobile introduced in #20008
How has this been tested?
This can be tested on GB-mobile here: wordpress-mobile/gutenberg-mobile#2245
Screenshots
Types of changes
Checklist: