Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow editing of new menu items from the block inspector #22210

Merged
merged 5 commits into from
May 18, 2020
Merged

Allow editing of new menu items from the block inspector #22210

merged 5 commits into from
May 18, 2020

Conversation

adamziel
Copy link
Contributor

@adamziel adamziel commented May 8, 2020 •
edited
Loading

Description

This is a follow-up to #21948
Fixes #20748.

It plugs RichText editor into those slots navigation-link/edit.js. As a result, it's possible to edit the label from the BlockNavigationList itself.

How has this been tested?

  1. Apply this PR and More accurate dependency list for useGenericPreviewBlock hook #22355

On experimental nav-menus page:

  1. Go to /wp-admin/admin.php?page=gutenberg-navigation

  2. Edit the text from the navigation structure panel like on the gif below:

  3. Try with both top-level and nested navigation items

In posts editor:

  1. Go to posts > add new
  2. Add navigation block with some nested items
  3. Try editing titles through the navigator in block inspector (slow! performance fix: Optimize BlockStyles by using hooks and React.memo (instead of HOCs) #21973):

Zrzut ekranu 2020-04-29 o 13 35 11

  1. Make sure to use rich formatting like pressing enter or using keyboard shortcuts (e.g. cmd+b on mac to bold selected text).

  2. Try editing titles through the navigator in modal:

Zrzut ekranu 2020-04-29 o 13 35 17

  1. Confirm global block navigation remains non-editable and only allows block selection on click:

Zrzut ekranu 2020-04-29 o 13 36 15

Screenshots

2020-04-28 16-01-11 2020-04-28 16_01_34

Types of changes

Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

@adamziel adamziel changed the base branch from master to add/navigation-menu-block/allow-editing-of-new-menu-items-from-the-block-inspector May 8, 2020 08:28
@github-actions
Copy link

github-actions bot commented May 8, 2020 •
edited
Loading

Size Change: +100 B (0%)

Total Size: 833 kB

Filename Size Change
build/block-editor/index.js 104 kB +86 B (0%)
build/block-library/index.js 118 kB +14 B (0%)
ℹ️ View Unchanged
Filename Size Change
build/a11y/index.js 1.02 kB 0 B
build/annotations/index.js 3.62 kB 0 B
build/api-fetch/index.js 3.39 kB 0 B
build/autop/index.js 2.83 kB 0 B
build/blob/index.js 620 B 0 B
build/block-directory/index.js 6.59 kB 0 B
build/block-directory/style-rtl.css 764 B 0 B
build/block-directory/style.css 764 B 0 B
build/block-editor/style-rtl.css 10.8 kB 0 B
build/block-editor/style.css 10.8 kB 0 B
build/block-library/editor-rtl.css 7.25 kB 0 B
build/block-library/editor.css 7.25 kB 0 B
build/block-library/style-rtl.css 7.48 kB 0 B
build/block-library/style.css 7.49 kB 0 B
build/block-library/theme-rtl.css 683 B 0 B
build/block-library/theme.css 685 B 0 B
build/block-serialization-default-parser/index.js 1.88 kB 0 B
build/block-serialization-spec-parser/index.js 3.1 kB 0 B
build/blocks/index.js 48.1 kB 0 B
build/components/index.js 182 kB 0 B
build/components/style-rtl.css 17.1 kB 0 B
build/components/style.css 17 kB 0 B
build/compose/index.js 6.68 kB 0 B
build/core-data/index.js 11.4 kB 0 B
build/data-controls/index.js 1.29 kB 0 B
build/data/index.js 8.43 kB 0 B
build/date/index.js 5.47 kB 0 B
build/deprecated/index.js 772 B 0 B
build/dom-ready/index.js 568 B 0 B
build/dom/index.js 3.1 kB 0 B
build/edit-navigation/index.js 5.6 kB 0 B
build/edit-navigation/style-rtl.css 618 B 0 B
build/edit-navigation/style.css 617 B 0 B
build/edit-post/index.js 28.2 kB 0 B
build/edit-post/style-rtl.css 12.2 kB 0 B
build/edit-post/style.css 12.2 kB 0 B
build/edit-site/index.js 12 kB 0 B
build/edit-site/style-rtl.css 5.22 kB 0 B
build/edit-site/style.css 5.22 kB 0 B
build/edit-widgets/index.js 8.47 kB 0 B
build/edit-widgets/style-rtl.css 4.69 kB 0 B
build/edit-widgets/style.css 4.69 kB 0 B
build/editor/editor-styles-rtl.css 425 B 0 B
build/editor/editor-styles.css 428 B 0 B
build/editor/index.js 44.3 kB 0 B
build/editor/style-rtl.css 5.07 kB 0 B
build/editor/style.css 5.08 kB 0 B
build/element/index.js 4.65 kB 0 B
build/escape-html/index.js 733 B 0 B
build/format-library/index.js 7.63 kB 0 B
build/format-library/style-rtl.css 502 B 0 B
build/format-library/style.css 502 B 0 B
build/hooks/index.js 2.13 kB 0 B
build/html-entities/index.js 622 B 0 B
build/i18n/index.js 3.56 kB 0 B
build/is-shallow-equal/index.js 712 B 0 B
build/keyboard-shortcuts/index.js 2.51 kB 0 B
build/keycodes/index.js 1.94 kB 0 B
build/list-reusable-blocks/index.js 3.13 kB 0 B
build/list-reusable-blocks/style-rtl.css 226 B 0 B
build/list-reusable-blocks/style.css 226 B 0 B
build/media-utils/index.js 5.29 kB 0 B
build/notices/index.js 1.79 kB 0 B
build/nux/index.js 3.4 kB 0 B
build/nux/style-rtl.css 616 B 0 B
build/nux/style.css 613 B 0 B
build/plugins/index.js 2.56 kB 0 B
build/primitives/index.js 1.5 kB 0 B
build/priority-queue/index.js 789 B 0 B
build/redux-routine/index.js 2.85 kB 0 B
build/rich-text/index.js 14.8 kB 0 B
build/server-side-render/index.js 2.68 kB 0 B
build/shortcode/index.js 1.7 kB 0 B
build/token-list/index.js 1.28 kB 0 B
build/url/index.js 4.02 kB 0 B
build/viewport/index.js 1.84 kB 0 B
build/warning/index.js 1.14 kB 0 B
build/wordcount/index.js 1.18 kB 0 B

compressed-size-action

@adamziel adamziel mentioned this pull request May 8, 2020
Merged
6 tasks
@adamziel adamziel changed the base branch from add/navigation-menu-block/allow-editing-of-new-menu-items-from-the-block-inspector to master May 8, 2020 14:52
@adamziel adamziel force-pushed the add/navigation-menu-block/allow-editing-of-new-menu-items-from-the-block-inspector-fill branch from 0d3ea95 to d0da2af Compare May 8, 2020 14:56
@adamziel adamziel requested a review from talldan May 8, 2020 14:57
@adamziel adamziel marked this pull request as ready for review May 8, 2020 15:00
@adamziel adamziel force-pushed the add/navigation-menu-block/allow-editing-of-new-menu-items-from-the-block-inspector-fill branch from d0da2af to ea92918 Compare May 11, 2020 14:45
@noisysocks noisysocks mentioned this pull request May 13, 2020
Closed
@draganescu
Copy link
Contributor

I tested this and it works all right, the performance in the editor is good even with larger menus.

@adamziel adamziel force-pushed the add/navigation-menu-block/allow-editing-of-new-menu-items-from-the-block-inspector-fill branch from ea92918 to 1854fa0 Compare May 14, 2020 13:57
@adamziel
Copy link
Contributor Author

@draganescu would you mind approving if it works well? :-)

draganescu
draganescu approved these changes May 18, 2020
View reviewed changes
Copy link
Contributor

@draganescu draganescu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot to approve! Here you go @adamziel :shipit:

@adamziel adamziel merged commit d2c828b into master May 18, 2020
@adamziel adamziel deleted the add/navigation-menu-block/allow-editing-of-new-menu-items-from-the-block-inspector-fill branch May 18, 2020 07:08
@github-actions github-actions bot added this to the Gutenberg 8.2 milestone May 18, 2020
@talldan talldan mentioned this pull request May 20, 2020
Closed
@adamziel adamziel mentioned this pull request May 26, 2020
Merged
6 tasks
@talldan talldan mentioned this pull request Jul 26, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@talldan talldan talldan left review comments

@draganescu draganescu draganescu approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra

@jorgefilipecosta jorgefilipecosta Awaiting requested review from jorgefilipecosta

@Soean Soean Awaiting requested review from Soean

@ellatrix ellatrix Awaiting requested review from ellatrix

@youknowriad youknowriad Awaiting requested review from youknowriad

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Gutenberg 8.2
Development

Successfully merging this pull request may close these issues.

Navigation menu block: allow editing of new menu items from the block inspector UI
3 participants
@adamziel @draganescu @talldan